You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2016/02/25 11:44:11 UTC
Review Request 44000: When user does not have permission to view a
file, empty preview window is shown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
Bugs: AMBARI-15179
https://issues.apache.org/jira/browse/AMBARI-15179
Repository: ambari
Description
-------
for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
Diffs
-----
contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
contrib/views/files/src/main/resources/ui/app/services/file-preview.js 2dc8558
contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 98a5459
Diff: https://reviews.apache.org/r/44000/diff/
Testing
-------
manually testing done. Not breaking any test cases.
Here are the logs.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.filebrowser.FilebrowserTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
Results :
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 107 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
[INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
[INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.025s
[INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
[INFO] Final Memory: 50M/787M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by Dipayan Bhowmick <di...@gmail.com>.
Pallav,
I don't see the new revision in the review board. Did you update the patch
in the review board.
Thanks,
Dipayan.
On Mon, Feb 29, 2016 at 10:24 PM, Pallav Kulshreshtha <pa...@gmail.com>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44000/
>
> On February 25th, 2016, 10:53 a.m. UTC, *DIPAYAN BHOWMICK* wrote:
>
>
> contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js
> <https://reviews.apache.org/r/44000/diff/1/?file=1270784#file1270784line75> (Diff
> revision 1)
>
> didInitAttrs: function() {
>
> didInitAttrs: function () {
>
> 73
>
> this.get('modalEventBus').showModal('ctx-open');
>
> 75
>
> this.get('filePreviewService').getNextContent().then(function () {
>
> Move this code to open preview modal. Let preview modal handle this. If there is no permission, then the modal closes itself which writing a error message to the alert logger.
>
> Done.
>
>
> On February 25th, 2016, 10:53 a.m. UTC, *DIPAYAN BHOWMICK* wrote:
>
> contrib/views/files/src/main/resources/ui/app/services/file-preview.js
> <https://reviews.apache.org/r/44000/diff/1/?file=1270786#file1270786line40> (Diff
> revision 1)
> 39
>
> 40
>
> errorMessage: '',
>
> Where are you using this errorMessage and hasError variable?
>
> Not using so removed it in the new patch.
>
>
> - Pallav
>
> On February 25th, 2016, 10:44 a.m. UTC, Pallav Kulshreshtha wrote:
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin
> Jetly.
> By Pallav Kulshreshtha.
>
> *Updated Feb. 25, 2016, 10:44 a.m.*
> *Bugs: * AMBARI-15179 <https://issues.apache.org/jira/browse/AMBARI-15179>
> *Repository: * ambari
> Description
>
> for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
>
> Testing
>
> manually testing done. Not breaking any test cases.
>
> Here are the logs.
> ------------------------------
> T E S T S
> ------------------------------
> T E S T S
>
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
> Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
>
> Results :
>
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: */.gitignore
> [INFO] Exclude: */.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: */target/*
> [INFO] Exclude: */.gitkeep
> [INFO] Exclude: */.bowerrc
> [INFO] Exclude: */.editorconfig
> [INFO] Exclude: */.jshintrc
> [INFO] Exclude: */.tmp/*
> [INFO] Exclude: */tmp/*
> [INFO] Exclude: */*.json
> [INFO] Exclude: */*.svg
> [INFO] Exclude: /vendor/
> [INFO] Exclude: /bin
> [INFO] Exclude: /node_modules/
> [INFO] Exclude: /vendor/
> [INFO] Exclude: /public/
> [INFO] Exclude: /dist/
> [INFO] Exclude: /bower_components/
> [INFO] Exclude: /bower/
> [INFO] Exclude: /node/
> [INFO] Exclude: /runner.js
> [INFO] Exclude: /assets/javascripts/
> [INFO] Exclude: /assets/stylesheets/
> [INFO] Exclude: /assets/static/javascripts/
> [INFO] Exclude: /assets/static/stylesheets/
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 107 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.025s
> [INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
> [INFO] Final Memory: 50M/787M
> [INFO] ------------------------------------------------------------------------
>
> Diffs
>
> - contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js
> (1e9551b)
> - contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js
> (bc60227)
> - contrib/views/files/src/main/resources/ui/app/services/file-preview.js
> (2dc8558)
> - contrib/views/files/src/main/resources/ui/app/styles/app.less
> (55327e9)
> - contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs
> (98a5459)
>
> View Diff <https://reviews.apache.org/r/44000/diff/>
>
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
> On Feb. 25, 2016, 10:53 a.m., DIPAYAN BHOWMICK wrote:
> > contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js, line 75
> > <https://reviews.apache.org/r/44000/diff/1/?file=1270784#file1270784line75>
> >
> > Move this code to open preview modal. Let preview modal handle this. If there is no permission, then the modal closes itself which writing a error message to the alert logger.
Done.
> On Feb. 25, 2016, 10:53 a.m., DIPAYAN BHOWMICK wrote:
> > contrib/views/files/src/main/resources/ui/app/services/file-preview.js, line 40
> > <https://reviews.apache.org/r/44000/diff/1/?file=1270786#file1270786line40>
> >
> > Where are you using this errorMessage and hasError variable?
Not using so removed it in the new patch.
- Pallav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/#review120684
-----------------------------------------------------------
On Feb. 25, 2016, 10:44 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44000/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 10:44 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
>
>
> Bugs: AMBARI-15179
> https://issues.apache.org/jira/browse/AMBARI-15179
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
> contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
> contrib/views/files/src/main/resources/ui/app/services/file-preview.js 2dc8558
> contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
> contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 98a5459
>
> Diff: https://reviews.apache.org/r/44000/diff/
>
>
> Testing
> -------
>
> manually testing done. Not breaking any test cases.
>
> Here are the logs.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
> Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
>
> Results :
>
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 107 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.025s
> [INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
> [INFO] Final Memory: 50M/787M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/#review120684
-----------------------------------------------------------
contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js (line 75)
<https://reviews.apache.org/r/44000/#comment182143>
Move this code to open preview modal. Let preview modal handle this. If there is no permission, then the modal closes itself which writing a error message to the alert logger.
contrib/views/files/src/main/resources/ui/app/services/file-preview.js (line 40)
<https://reviews.apache.org/r/44000/#comment182142>
Where are you using this errorMessage and hasError variable?
- DIPAYAN BHOWMICK
On Feb. 25, 2016, 10:44 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44000/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 10:44 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
>
>
> Bugs: AMBARI-15179
> https://issues.apache.org/jira/browse/AMBARI-15179
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
> contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
> contrib/views/files/src/main/resources/ui/app/services/file-preview.js 2dc8558
> contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
> contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 98a5459
>
> Diff: https://reviews.apache.org/r/44000/diff/
>
>
> Testing
> -------
>
> manually testing done. Not breaking any test cases.
>
> Here are the logs.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
> Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
>
> Results :
>
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 107 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.025s
> [INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
> [INFO] Final Memory: 50M/787M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
> On Feb. 29, 2016, 5:19 p.m., DIPAYAN BHOWMICK wrote:
> > contrib/views/files/src/main/resources/ui/app/services/file-preview.js, line 69
> > <https://reviews.apache.org/r/44000/diff/2/?file=1274031#file1274031line69>
> >
> > Error in merging the code, old code got replaced. This code got changed in https://issues.apache.org/jira/browse/AMBARI-15176.
> >
> > Rebase properly and update the patch.
Looks like there is some code override. I'll rebase it and will update the patch.
- Pallav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/#review121258
-----------------------------------------------------------
On Feb. 29, 2016, 5:11 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44000/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 5:11 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
>
>
> Bugs: AMBARI-15179
> https://issues.apache.org/jira/browse/AMBARI-15179
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
> contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
> contrib/views/files/src/main/resources/ui/app/services/file-preview.js 7691e5e
> contrib/views/files/src/main/resources/ui/app/services/files-download.js 7624b53
> contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
> contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 7c4b0a8
>
> Diff: https://reviews.apache.org/r/44000/diff/
>
>
> Testing
> -------
>
> manually testing done. Not breaking any test cases.
>
> Here are the logs.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
> Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
>
> Results :
>
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 107 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.025s
> [INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
> [INFO] Final Memory: 50M/787M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
> On Feb. 29, 2016, 5:19 p.m., DIPAYAN BHOWMICK wrote:
> > contrib/views/files/src/main/resources/ui/app/services/file-preview.js, line 38
> > <https://reviews.apache.org/r/44000/diff/2/?file=1274031#file1274031line38>
> >
> > What is the need of hasError?
Not needed now, removed.
- Pallav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/#review121258
-----------------------------------------------------------
On Feb. 29, 2016, 6:02 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44000/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 6:02 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
>
>
> Bugs: AMBARI-15179
> https://issues.apache.org/jira/browse/AMBARI-15179
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
> contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
> contrib/views/files/src/main/resources/ui/app/services/file-preview.js 7691e5e
> contrib/views/files/src/main/resources/ui/app/services/files-download.js 7624b53
> contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
> contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 7c4b0a8
>
> Diff: https://reviews.apache.org/r/44000/diff/
>
>
> Testing
> -------
>
> manually testing done. Not breaking any test cases.
>
> Here are the logs.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
> Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
>
> Results :
>
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 107 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.025s
> [INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
> [INFO] Final Memory: 50M/787M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/#review121258
-----------------------------------------------------------
contrib/views/files/src/main/resources/ui/app/services/file-preview.js (line 38)
<https://reviews.apache.org/r/44000/#comment182939>
What is the need of hasError?
contrib/views/files/src/main/resources/ui/app/services/file-preview.js (line 67)
<https://reviews.apache.org/r/44000/#comment182938>
Error in merging the code, old code got replaced. This code got changed in https://issues.apache.org/jira/browse/AMBARI-15176.
Rebase properly and update the patch.
- DIPAYAN BHOWMICK
On Feb. 29, 2016, 5:11 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44000/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 5:11 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
>
>
> Bugs: AMBARI-15179
> https://issues.apache.org/jira/browse/AMBARI-15179
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
> contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
> contrib/views/files/src/main/resources/ui/app/services/file-preview.js 7691e5e
> contrib/views/files/src/main/resources/ui/app/services/files-download.js 7624b53
> contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
> contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 7c4b0a8
>
> Diff: https://reviews.apache.org/r/44000/diff/
>
>
> Testing
> -------
>
> manually testing done. Not breaking any test cases.
>
> Here are the logs.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
> Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
>
> Results :
>
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 107 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.025s
> [INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
> [INFO] Final Memory: 50M/787M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/#review121272
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 29, 2016, 6:02 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44000/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 6:02 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
>
>
> Bugs: AMBARI-15179
> https://issues.apache.org/jira/browse/AMBARI-15179
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
> contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
> contrib/views/files/src/main/resources/ui/app/services/file-preview.js 7691e5e
> contrib/views/files/src/main/resources/ui/app/services/files-download.js 7624b53
> contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
> contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 7c4b0a8
>
> Diff: https://reviews.apache.org/r/44000/diff/
>
>
> Testing
> -------
>
> manually testing done. Not breaking any test cases.
>
> Here are the logs.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
> Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
>
> Results :
>
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 107 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.025s
> [INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
> [INFO] Final Memory: 50M/787M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 6:02 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
Bugs: AMBARI-15179
https://issues.apache.org/jira/browse/AMBARI-15179
Repository: ambari
Description
-------
for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
Diffs (updated)
-----
contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
contrib/views/files/src/main/resources/ui/app/services/file-preview.js 7691e5e
contrib/views/files/src/main/resources/ui/app/services/files-download.js 7624b53
contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 7c4b0a8
Diff: https://reviews.apache.org/r/44000/diff/
Testing
-------
manually testing done. Not breaking any test cases.
Here are the logs.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.filebrowser.FilebrowserTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
Results :
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 107 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
[INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
[INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.025s
[INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
[INFO] Final Memory: 50M/787M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha
Re: Review Request 44000: When user does not have permission to view
a file, empty preview window is shown
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44000/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 5:11 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Jaimin Jetly.
Bugs: AMBARI-15179
https://issues.apache.org/jira/browse/AMBARI-15179
Repository: ambari
Description
-------
for fixing this bug, I'm not at all opening the modal if first call of the preview fails. I'm displaying error message then and there without modal open.
Diffs (updated)
-----
contrib/views/files/src/main/resources/ui/app/components/context-row-menu.js 1e9551b
contrib/views/files/src/main/resources/ui/app/components/open-preview-modal.js bc60227
contrib/views/files/src/main/resources/ui/app/services/file-preview.js 7691e5e
contrib/views/files/src/main/resources/ui/app/services/files-download.js 7624b53
contrib/views/files/src/main/resources/ui/app/styles/app.less 55327e9
contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 7c4b0a8
Diff: https://reviews.apache.org/r/44000/diff/
Testing
-------
manually testing done. Not breaking any test cases.
Here are the logs.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.filebrowser.FilebrowserTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.601 sec
Running org.apache.ambari.view.filebrowser.PropertyValidatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
Results :
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 107 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 107 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
[INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
[INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.025s
[INFO] Finished at: Thu Feb 25 16:10:53 IST 2016
[INFO] Final Memory: 50M/787M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha