You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2009/07/23 20:36:14 UTC

[jira] Created: (AVRO-83) specific generated code should optimize unions with null

specific generated code should optimize unions with null
--------------------------------------------------------

                 Key: AVRO-83
                 URL: https://issues.apache.org/jira/browse/AVRO-83
             Project: Avro
          Issue Type: Improvement
          Components: java
    Affects Versions: 1.0.0
            Reporter: Doug Cutting


The Java type generated for unions is Object, but a union between type T and null would be better generated as just T, to avoid the need for casts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-83) specific generated code should optimize unions with null

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-83:
-----------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> specific generated code should optimize unions with null
> --------------------------------------------------------
>
>                 Key: AVRO-83
>                 URL: https://issues.apache.org/jira/browse/AVRO-83
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.0.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.0.1
>
>         Attachments: AVRO-83.patch
>
>
> The Java type generated for unions is Object, but a union between type T and null would be better generated as just T, to avoid the need for casts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-83) specific generated code should optimize unions with null

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-83:
-----------------------------

    Fix Version/s: 1.0.1
         Assignee: Doug Cutting
           Status: Patch Available  (was: Open)

> specific generated code should optimize unions with null
> --------------------------------------------------------
>
>                 Key: AVRO-83
>                 URL: https://issues.apache.org/jira/browse/AVRO-83
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.0.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.0.1
>
>         Attachments: AVRO-83.patch
>
>
> The Java type generated for unions is Object, but a union between type T and null would be better generated as just T, to avoid the need for casts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-83) specific generated code should optimize unions with null

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-83:
-----------------------------

    Attachment: AVRO-83.patch

Here's a patch that implements this.  No new tests are required, since the handshake includes unions with null that are generated by the specific compiler and tested.

> specific generated code should optimize unions with null
> --------------------------------------------------------
>
>                 Key: AVRO-83
>                 URL: https://issues.apache.org/jira/browse/AVRO-83
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.0.0
>            Reporter: Doug Cutting
>             Fix For: 1.0.1
>
>         Attachments: AVRO-83.patch
>
>
> The Java type generated for unions is Object, but a union between type T and null would be better generated as just T, to avoid the need for casts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.