You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/11 01:21:05 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37133: [SPARK-39720][R] Implement tableExists/getTable in SparkR for 3L namespace

HyukjinKwon commented on code in PR #37133:
URL: https://github.com/apache/spark/pull/37133#discussion_r917480519


##########
R/pkg/R/catalog.R:
##########
@@ -118,6 +118,7 @@ createExternalTable <- function(tableName, path = NULL, source = NULL, schema =
 #'
 #' @param tableName the qualified or unqualified name that designates a table. If no database
 #'                  identifier is provided, it refers to a table in the current database.
+#'                  Since 3.4.0 it is allowed to be qualified with catalog name.

Review Comment:
   it sounds slightly awkward (to me). I would write like, "The table name can be fully qualified with catalog name since 3.4.0."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org