You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2024/12/21 02:17:56 UTC
[PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
beliefer opened a new pull request, #25835:
URL: https://github.com/apache/flink/pull/25835
## What is the purpose of the change
This PR propose to deprecated StreamSink and SinkOperator.
## Brief change log
Add the annotation Deprecated for StreamSink and SinkOperator.
## Verifying this change
This change is a trivial rework cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25835:
URL: https://github.com/apache/flink/pull/25835#discussion_r1910577181
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java:
##########
@@ -25,6 +25,7 @@
import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
/** A {@link StreamOperator} for executing {@link SinkFunction SinkFunctions}. */
+@Deprecated
Review Comment:
I am unsure why we are deprecating these methods. `SinkFunction`is not tagged as deprecated - some its methods are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25835:
URL: https://github.com/apache/flink/pull/25835#issuecomment-2557962119
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ce6f8cc3582de3d86bbe4f8111873b9ea530d2b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ce6f8cc3582de3d86bbe4f8111873b9ea530d2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ce6f8cc3582de3d86bbe4f8111873b9ea530d2b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #25835:
URL: https://github.com/apache/flink/pull/25835#discussion_r1911925092
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java:
##########
@@ -25,6 +25,7 @@
import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
/** A {@link StreamOperator} for executing {@link SinkFunction SinkFunctions}. */
+@Deprecated
Review Comment:
```
@Internal
@Deprecated
public interface SinkFunction<IN> extends Function, Serializable {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer closed pull request #25835: [MINOR] Deprecated StreamSink and SinkOperator
URL: https://github.com/apache/flink/pull/25835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25835:
URL: https://github.com/apache/flink/pull/25835#issuecomment-2583051317
Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #25835:
URL: https://github.com/apache/flink/pull/25835#issuecomment-2652603360
cc @1996fanrui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #25835:
URL: https://github.com/apache/flink/pull/25835#issuecomment-2653078973
@davidradl got it. Thank you for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #25835:
URL: https://github.com/apache/flink/pull/25835#discussion_r1910342031
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java:
##########
@@ -25,6 +25,7 @@
import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
/** A {@link StreamOperator} for executing {@link SinkFunction SinkFunctions}. */
+@Deprecated
Review Comment:
So do I. But the annotation exists in project all without comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25835:
URL: https://github.com/apache/flink/pull/25835#discussion_r1908955091
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java:
##########
@@ -25,6 +25,7 @@
import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
/** A {@link StreamOperator} for executing {@link SinkFunction SinkFunctions}. */
+@Deprecated
Review Comment:
With the addition of deprecation, it is usual to indicate in the comments that the method is deprecated (maybe in including the reason) what should be used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org