You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/04 18:05:00 UTC
[jira] [Work logged] (BEAM-9799) Add automated RTracker validation
to Go SDF
[ https://issues.apache.org/jira/browse/BEAM-9799?focusedWorklogId=430335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430335 ]
ASF GitHub Bot logged work on BEAM-9799:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/20 18:04
Start Date: 04/May/20 18:04
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #11553:
URL: https://github.com/apache/beam/pull/11553#discussion_r419623182
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -162,6 +168,14 @@ func (n *ParDo) processMainInput(mainIn *MainInput) error {
return nil
}
+func rtErrHelper(err error) error {
+ if err != nil {
+ return err
+ } else {
+ return errors.New("RTracker IsDone failed for unspecified reason")
+ }
Review comment:
```suggestion
}
return errors.New("RTracker.IsDone() failed for unspecified reason")
```
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -162,6 +168,14 @@ func (n *ParDo) processMainInput(mainIn *MainInput) error {
return nil
}
+func rtErrHelper(err error) error {
+ if err != nil {
+ return err
+ } else {
+ return errors.New("RTracker IsDone failed for unspecified reason")
+ }
Review comment:
Also, in both places this is called, error or no, we don't know IsDone failed(), we know that the DoFn terminated without fully processing the restriction (If I understand IsDone's semantics correctly). Perhaps the message should indicate that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 430335)
Time Spent: 0.5h (was: 20m)
> Add automated RTracker validation to Go SDF
> -------------------------------------------
>
> Key: BEAM-9799
> URL: https://issues.apache.org/jira/browse/BEAM-9799
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> After finishing executing an SDF we should be validating the restriction trackers to make sure they succeeded without errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)