You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2012/06/15 18:47:43 UTC

[jira] [Resolved] (JCR-3335) Reduce synchronized block scope when loading a node by id

     [ https://issues.apache.org/jira/browse/JCR-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke resolved JCR-3335.
---------------------------------

    Resolution: Fixed

This has been addressed as part of r1350686, see JCR-2950.

Note that this change should reduce blocking on the cache, but might add additional load on the persistence, because now we might be fetching ACL information for the same node in parallel (where before it was serialized).

If this turns out to be a problem we can try various things:

- synchronize updateCache
- optimize fetching the ACLs
- optimize filling the cache for parent nodes
- serializing the fetching per nodeId

We probably should wait with this until we have benchmarks.

                
> Reduce synchronized block scope when loading a node by id
> ---------------------------------------------------------
>
>                 Key: JCR-3335
>                 URL: https://issues.apache.org/jira/browse/JCR-3335
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>            Reporter: Alex Parvulescu
>         Attachments: CachingEntryCollector.java.patch
>
>
> This is a small(ish) change that takes the 'getNodeById' cll outside of the synchronized block that wraps the cache access.
> I see the load call as a heavy one, and the proposed change offers better concurrency behavior.
> In the tests that I ran, mostly related to queries I got a 20% improvement on average query response time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira