You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "William R. Speirs (Created) (JIRA)" <ji...@apache.org> on 2011/12/03 18:42:40 UTC
[jira] [Created] (HTTPCORE-284) Add setRequestLine method to
HttpRequest
Add setRequestLine method to HttpRequest
----------------------------------------
Key: HTTPCORE-284
URL: https://issues.apache.org/jira/browse/HTTPCORE-284
Project: HttpComponents HttpCore
Issue Type: Improvement
Components: HttpCore
Reporter: William R. Speirs
Priority: Minor
Fix For: 4.1.4, 4.2-alpha3
The HttpRequest interface has a getRequestLine method, but not a setRequestLine method. Not having this method makes it very difficult for programs like proxies to modify URIs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-284) Add setRequestLine method to
HttpRequest
Posted by "William R. Speirs (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162409#comment-13162409 ]
William R. Speirs commented on HTTPCORE-284:
--------------------------------------------
What about just adding the method to the classes and not the interface? Poor way to go, but should keep API compatibility and get it out the door sooner.
> Add setRequestLine method to HttpRequest
> ----------------------------------------
>
> Key: HTTPCORE-284
> URL: https://issues.apache.org/jira/browse/HTTPCORE-284
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Reporter: William R. Speirs
> Priority: Minor
> Fix For: Future
>
> Attachments: HTTPCORE-284.diff
>
>
> The HttpRequest interface has a getRequestLine method, but not a setRequestLine method. Not having this method makes it very difficult for programs like proxies to modify URIs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCORE-284) Add setRequestLine method to
HttpRequest
Posted by "William R. Speirs (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William R. Speirs updated HTTPCORE-284:
---------------------------------------
Attachment: HTTPCORE-284.diff
Patch includes a setRequestLine method for HttpRequest and BasicHttpRequest, and a test case.
> Add setRequestLine method to HttpRequest
> ----------------------------------------
>
> Key: HTTPCORE-284
> URL: https://issues.apache.org/jira/browse/HTTPCORE-284
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Reporter: William R. Speirs
> Priority: Minor
> Fix For: 4.1.4, 4.2-alpha3
>
> Attachments: HTTPCORE-284.diff
>
>
> The HttpRequest interface has a getRequestLine method, but not a setRequestLine method. Not having this method makes it very difficult for programs like proxies to modify URIs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-284) Add setRequestLine method to
HttpRequest
Posted by "Oleg Kalnichevski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162412#comment-13162412 ]
Oleg Kalnichevski commented on HTTPCORE-284:
--------------------------------------------
Sure, this can be done.
One a general note, though, one actually _should_ create a completely new request object in a proxy scenario, not only to ensure hop-by-hop headers do not get passed to the next hop, but also to have the original, unmodified request when deciding whether or not the incoming connection can be kept alive.
Oleg
> Add setRequestLine method to HttpRequest
> ----------------------------------------
>
> Key: HTTPCORE-284
> URL: https://issues.apache.org/jira/browse/HTTPCORE-284
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Reporter: William R. Speirs
> Priority: Minor
> Fix For: Future
>
> Attachments: HTTPCORE-284.diff
>
>
> The HttpRequest interface has a getRequestLine method, but not a setRequestLine method. Not having this method makes it very difficult for programs like proxies to modify URIs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCORE-284) Add setRequestLine method to
HttpRequest
Posted by "Oleg Kalnichevski (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCORE-284:
---------------------------------------
Fix Version/s: (was: 4.2-alpha3)
(was: 4.1.4)
Future
Unfortunately the earliest time this could be done would be 5.0.
Oleg
> Add setRequestLine method to HttpRequest
> ----------------------------------------
>
> Key: HTTPCORE-284
> URL: https://issues.apache.org/jira/browse/HTTPCORE-284
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Reporter: William R. Speirs
> Priority: Minor
> Fix For: Future
>
> Attachments: HTTPCORE-284.diff
>
>
> The HttpRequest interface has a getRequestLine method, but not a setRequestLine method. Not having this method makes it very difficult for programs like proxies to modify URIs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org