You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by liming01 <gi...@git.apache.org> on 2016/01/06 08:48:38 UTC
[GitHub] incubator-hawq pull request: HAWQ-322. Fixed DROP TABLESPACE doesn...
GitHub user liming01 opened a pull request:
https://github.com/apache/incubator-hawq/pull/249
HAWQ-322. Fixed DROP TABLESPACE doesnot check sub-object(database/relation) in some cases
We need to check catalog (pg_database/pg_class) instead of related persistent table, because the persistent table doesn't hold lock until transaction end, so concurrency problem will occurs in previous implementation. Here we add code to check catalog.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liming01/incubator-hawq mli/drop_tblspc_chk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit 2bbbc335115d120006a36c3fd28ae31468aaa916
Author: Ming LI <ml...@pivotal.io>
Date: 2016-01-06T07:42:27Z
HAWQ-322. Fixed DROP TABLESPACE doesnot check sub-object(database/relation) in some cases
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-322. Fixed DROP TABLESPACE doesn...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-322. Fixed DROP TABLESPACE doesn...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/249#issuecomment-171516945
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-322. Fixed DROP TABLESPACE doesn...
Posted by jianlirong <gi...@git.apache.org>.
Github user jianlirong commented on the pull request:
https://github.com/apache/incubator-hawq/pull/249#issuecomment-171515917
+1, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---