You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/27 10:04:44 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #3145: Upgrade ZooKeeper to 3.8.0
eolivelli opened a new pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145
### Motivation
We are using an old version of ZooKeeper, 3.6.x (and ZooKeeper 3.5.x was declared EOL a few weeks ago).
We should upgrade to the latest version.
### Changes
Upgraded ZooKeeper dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #3145: Upgrade ZooKeeper to 3.8.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145#discussion_r837451876
##########
File path: dependencies.gradle
##########
@@ -29,7 +29,7 @@ depVersions = [
commonsCli: "1.2",
commonsCodec: "1.6",
commonsCollections4: "4.1",
- commonsCompress: "1.21",
+ commonsCompress: "1.19",
Review comment:
good catch. I picked up a old version of the file from master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli removed a comment on pull request #3145: Upgrade ZooKeeper to 3.8.0
Posted by GitBox <gi...@apache.org>.
eolivelli removed a comment on pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145#issuecomment-1080315877
I have temporary cherry-picked these patches to unlock CI
- https://github.com/apache/bookkeeper/pull/3148
- https://github.com/apache/bookkeeper/pull/3149
it it better to at least commit #3149, then I will rebase this patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3145: Upgrade ZooKeeper to 3.8.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145#issuecomment-1079904971
> Can you add owasp suppressions?
sure, I was just working on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #3145: Upgrade ZooKeeper to 3.8.0
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145#discussion_r836145531
##########
File path: dependencies.gradle
##########
@@ -29,7 +29,7 @@ depVersions = [
commonsCli: "1.2",
commonsCodec: "1.6",
commonsCollections4: "4.1",
- commonsCompress: "1.21",
+ commonsCompress: "1.19",
Review comment:
why this one?
1.19 is vulnerable
we have 1.21 in Maven pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3145: Upgrade ZooKeeper to 3.8.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145#issuecomment-1081651545
the failed test passes locally on my laptop
```
org.apache.bookkeeper.test.BookieZKExpireTest.testBookieServerZKExpireBehaviour
Error: Run 1: BookieZKExpireTest.testBookieServerZKExpireBehaviour:103 Bookie should not shutdown on losing zk session
Error: Run 2: BookieZKExpireTest.testBookieServerZKExpireBehaviour:103 Bookie should not shutdown on losing zk session
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3145: Upgrade ZooKeeper to 3.8.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145#issuecomment-1080315877
I have temporary cherry-picked these patches to unlock CI
- https://github.com/apache/bookkeeper/pull/3148
- https://github.com/apache/bookkeeper/pull/3149
it it better to at least commit #3149, then I will rebase this patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3145: Upgrade ZooKeeper to 3.8.0
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #3145:
URL: https://github.com/apache/bookkeeper/pull/3145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org