[GitHub] [ignite] NSAmelchev commented on issue #6701: IGNITE-11961 Provide JMX metrics for PME timings

[GitBox <gi...@apache.org>]

NSAmelchev commented on issue #6701: IGNITE-11961  Provide JMX metrics for PME timings
URL: https://github.com/apache/ignite/pull/6701#issuecomment-515372120
 
 
   > @NSAmelchev
   > @anton-vinogradov
   > 
   > I thought we should **add** new metrics to calculate blocking period.
   > Don't think we should remove existing metrics for a whole PME duration.
   > 
   > In the end we should have:
   > 
   >     * `CurrentPMEDuration` (existing metric, we shouldn't touch it, will be migrated to new framework in [IGNITE-11922](https://issues.apache.org/jira/browse/IGNITE-11922?jql=labels%20%3D%20IEP-35%20ORDER%20BY%20status%20ASC)).
   > 
   >     * `CurrentPMECacheOperationsBlockedDuration` - new long metric. only in the new framework, don't appear in `ClusterMetrics` JMX bean.
   > 
   >     * `PMEDuration` - new histogram.
   > 
   >     * `PMECacheOperationsBlockedDuration` - new histogram.
   > 
   > 
   > WDYT?
   
   @nizhikov Nikolay,  I have asked this on dev-list and Igniters says that we can update current existing metric(not released yet). It will become redundant with implementing new metrics.
   
   I suggest implementing only two metrics as I have done. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services