You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/08/02 23:55:27 UTC
[kudu-CR] [util] fixed build on MacOS X
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3836
Change subject: [util] fixed build on MacOS X
......................................................................
[util] fixed build on MacOS X
This is a follow-up for a9265d92424dc305c480d6c44d006b8545bd2227.
Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
---
M src/kudu/util/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/3836/1
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] fixed build on MacOS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed build on MacOS X
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt
File src/kudu/util/CMakeLists.txt:
Line 209: dl
> weird... Adar asked if I needed to put this here, and I figured I didn't be
At my laptop the error looks like
ld: library not found for -ldl_exported
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/exported/libkudu_client.0.1.0.dylib] Error 1
make[1]: *** [src/kudu/client/CMakeFiles/kudu_client_exported.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
So, it seems the problem arises later when working with ADD_EXPORTABLE_LIBRARY for EXPORTED_UTIL_LIBS if we leave the 'dl' lib in the list of UTIL_LIBS.
Why target_link_libraries() does not brake on MacOS X -- I have no idea.
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed build on MacOS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3836
to look at the new patch set (#2).
Change subject: [util] fixed build on MacOS X
......................................................................
[util] fixed build on MacOS X
This is a follow-up for a9265d92424dc305c480d6c44d006b8545bd2227.
Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
---
M src/kudu/util/CMakeLists.txt
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/3836/2
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [util] fixed build on MacOS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] fixed build on MacOS X
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt
File src/kudu/util/CMakeLists.txt:
Line 209: dl
> At my laptop the error looks like
It probably means -ldl can resolve to something on macOS, so kudu_test_main can link properly. However, Kudu's main CMakeLists.txt file does NOT create dl and dl_exported targets on macOS, so when the dl dependency sneaks into ADD_EXPORTABLY_LIBRARY(), -ldl_exported cannot resolve.
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed build on MacOS X
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [util] fixed build on MacOS X
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2710/
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [util] fixed build on MacOS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] fixed build on MacOS X
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [util] fixed build on MacOS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [util] fixed build on MacOS X
......................................................................
[util] fixed build on MacOS X
This is a follow-up for a9265d92424dc305c480d6c44d006b8545bd2227.
Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Reviewed-on: http://gerrit.cloudera.org:8080/3836
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/CMakeLists.txt
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [util] fixed build on MacOS X
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [util] fixed build on MacOS X
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt
File src/kudu/util/CMakeLists.txt:
Line 209: dl
weird... Adar asked if I needed to put this here, and I figured I didn't because we link 'dl' in the target_link_libraries(kudu_test_main...) stuff down aroudn line 257. Why does it work there and not here?
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed build on MacOS X
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [util] fixed build on MacOS X
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2707/
--
To view, visit http://gerrit.cloudera.org:8080/3836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No