[GitHub] [cordova-common] duanju commented on pull request #152: feat: setting config.xml value with environment variable

[GitBox <gi...@apache.org>]

duanju commented on pull request #152:
URL: https://github.com/apache/cordova-common/pull/152#issuecomment-687625661


   Actually, There are some cases that we need to change metadata of app based on build system and environment variables. It is useful and sometimes required. I list some scenarios in my project for the example: 
   
   1. We create app version number by the environment variable CI_JOB_ID which is created by gitlab CI system;
   2. We need update app name and icon by different environments in compile time. For example, for my one environment called 'DTMK' , i need change app name as 'DTMK-my-app-name';
   3. Some security key or ids also need to be updated in compile time by different environments.
   
   I googled and noticed there are persons achieved that by creating a temp_config file and copy it in hooks to replace config.xml, but i think that let the cordova-common lib to support the feature is more directly so this is why my commit. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org