You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/03/02 11:03:09 UTC

Review Request 44262: Cluster deadlock when calling create hosts api concurrently with host registration

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44262/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Myroslav Papirkovskyy.


Bugs: AMBARI-15166
    https://issues.apache.org/jira/browse/AMBARI-15166


Repository: ambari


Description
-------

Deadlock was detected by JVM.
Lock acquisition order should be changed in host registration event processing.
Currently Clusters object is called after host-local lock acquired.
Jstack thread dump attached.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java d5a4954 

Diff: https://reviews.apache.org/r/44262/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 44262: Cluster deadlock when calling create hosts api concurrently with host registration

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44262/#review121617
-----------------------------------------------------------


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Березень 2, 2016, 12:03 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44262/
> -----------------------------------------------------------
> 
> (Updated Березень 2, 2016, 12:03 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-15166
>     https://issues.apache.org/jira/browse/AMBARI-15166
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deadlock was detected by JVM.
> Lock acquisition order should be changed in host registration event processing.
> Currently Clusters object is called after host-local lock acquired.
> Jstack thread dump attached.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java d5a4954 
> 
> Diff: https://reviews.apache.org/r/44262/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 44262: Cluster deadlock when calling create hosts api concurrently with host registration

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44262/#review121620
-----------------------------------------------------------


Ship it!




Ship It!

- Dmytro Sen


On Март 2, 2016, 10:03 д.п., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44262/
> -----------------------------------------------------------
> 
> (Updated Март 2, 2016, 10:03 д.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-15166
>     https://issues.apache.org/jira/browse/AMBARI-15166
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deadlock was detected by JVM.
> Lock acquisition order should be changed in host registration event processing.
> Currently Clusters object is called after host-local lock acquired.
> Jstack thread dump attached.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java d5a4954 
> 
> Diff: https://reviews.apache.org/r/44262/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>