[GitHub] [beam] jubebo commented on a diff in pull request #27217: renamed dictionary variable addresses #27166

["jubebo (via GitHub)" <gi...@apache.org>]

jubebo commented on code in PR #27217:
URL: https://github.com/apache/beam/pull/27217#discussion_r1239510628


##########
sdks/python/apache_beam/io/gcp/bigquery_schema_tools.py:
##########
@@ -76,9 +76,9 @@ def generate_user_type_from_bq_schema(the_table_schema):
       raise ValueError(
           f"Encountered "
           f"an unsupported type: {the_schema['fields'][i]['type']!r}")
-    # TODO svetaksundhar@: Map remaining BQ types
-    dict_of_tuples.append((the_schema['fields'][i]['name'], typ))
-  sample_schema = beam.typehints.schemas.named_fields_to_schema(dict_of_tuples)
+    # TODO @svetaksundhar: Map remaining BQ types

Review Comment:
   Deleted this line as suggested



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org