You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/07/08 21:16:17 UTC
[GitHub] [cassandra] yifan-c commented on a diff in pull request #1658: CASSANDRA-17677: Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle
yifan-c commented on code in PR #1658:
URL: https://github.com/apache/cassandra/pull/1658#discussion_r917143009
##########
src/java/org/apache/cassandra/tools/LoaderOptions.java:
##########
@@ -60,10 +72,14 @@
public static final String IGNORE_NODES_OPTION = "ignore";
public static final String CONNECTIONS_PER_HOST = "connections-per-host";
public static final String CONFIG_PATH = "conf-path";
- public static final String THROTTLE_MBITS = "throttle";
- public static final String INTER_DC_THROTTLE_MBITS = "inter-dc-throttle";
- public static final String ENTIRE_SSTABLE_THROTTLE_MBITS = "entire-sstable-throttle";
- public static final String ENTIRE_SSTABLE_INTER_DC_THROTTLE_MBITS = "entire-sstable-inter-dc-throttle";
+ @Deprecated
+ public static final String THROTTLE_MEGABITS = "throttle";
+ public static final String THROTTLE_MEBIBYTES = "throttle-mib";
+ @Deprecated
+ public static final String INTER_DC_THROTTLE_MEGABITS = "inter-dc-throttle";
+ public static final String INTER_DC_THROTTLE_MEBIBYTES = "inter-dc-throttle-mib";
+ public static final String ENTIRE_SSTABLE_THROTTLE_MEBIBYTES = "entire-sstable-throttle-mib";
+ public static final String ENTIRE_SSTABLE_INTER_DC_THROTTLE_MEBIBYTES = "entire-sstable-inter-dc-throttle-mib";
Review Comment:
@frankgh, can you also revert the renaming in this PR? THX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org