You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by kiuby88 <gi...@git.apache.org> on 2015/05/27 09:32:13 UTC
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
GitHub user kiuby88 opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/661
FIX: library JsonPath was updated to 2.0.0
The JsonPath was updated to the last available version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kiuby88/incubator-brooklyn fix/JsonPath-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/661.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #661
----
commit 875d6aac2be0d60378758633a88e4d56c88ec6b3
Author: Kiuby88 <ki...@gmail.com>
Date: 2015-05-27T07:26:40Z
FIX: library JsonPath was updated to 2.0.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-105928827
good point @richardcloudsoft, we need to investigate a little more
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by kiuby88 <gi...@git.apache.org>.
Github user kiuby88 commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-107360765
@andreaturli I think v1.2.0 should work fine, but as @ahgittin I updated gson dependency to 2.3.X
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by kiuby88 <gi...@git.apache.org>.
Github user kiuby88 commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-106785839
Hi all,
Following the PaasLocation proposed in [pull 629] (https://github.com/apache/incubator-brooklyn/pull/629) @mbarrientos and I are defining an approach to allows to carry out the deployment of an application on [CloudFoundry from Brooklyn](https://github.com/kiuby88/brooklyn-location-cloudfoundry/tree/non-machinelocation).
In this project, we need parsing and extract some information from a Json, for this we use the indefinite expressions management provided by JsonPath, but the current version used by Brooklyn does not support several operators (such as `=`) which are necessary in our CloudFoundry management.
We are using version v2.0.0 because is the last available, of course we could use an older version, but from [v1.0.0](http://mvnrepository.com/artifact/com.jayway.jsonpath/json-path/1.0.0), gson v2.3.X is always used. Then, I think we could update jsonpath to v2.0.0 but we could exclude the gson v2.3.1 from jsonpath library and use the current version used by jclouds (v2.2.2). I have checked this point and it should works fine (for our project)
WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-106029477
meh dependencies. we should load jclouds via osgi.
google can be quite harsh in minor version changes so i agree, proceed with caution
@kiuby88 is there a need for 2.0.0 -- apart from wanting to use recent (and non-zero major) versions ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-106854324
ooh if jclouds 1.9 is on gson 2.3.x but brooklyn is on 2.2 that's bad. :)
we should increase brooklyn's version in any case.
i'm not worried between various 2.3.x.
@kiuby88 can you resubmit this PR bumping GSON to latest 2.3.x ? then if tests pass i think we're good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-105921769
According to http://mvnrepository.com/artifact/com.jayway.jsonpath/json-path/2.0.0 jsonPath:2.0.0 depends on `com.google.code.gson:gson:2.3.1` while brooklyn is using `2.2.2`
we probably need to update the `gson` dep as well. @richardcloudsoft, @grkvlt do you see any problems in that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-105923422
I think that Gson is a dependency of jclouds too. What version does jclouds depend on? Are these two dependencies going to introduce a conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-108130818
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: FIX: library JsonPath was updated...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/661#issuecomment-106793920
@richardcloudsoft, jclouds 1.9.0 uses [gson 2.3](https://github.com/jclouds/jclouds/blob/master/core/pom.xml#L80-L84) while
brooklyn uses [gson 2.2.2](https://github.com/apache/incubator-brooklyn/blob/321d8879068c1d5a159962c486c3851c2eaa64b8/pom.xml#L148)
I think @ahgittin is right, we should try to use osgi for jclouds and for everything it is possible, but meanwhile I think having the same gson version won't hurt (gson 2.3)
@kiuby88 would be jsonPath [v1.2.0](http://mvnrepository.com/artifact/com.jayway.jsonpath/json-path/1.2.0) ok for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---