You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/03 13:57:35 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5403: bcm43xxx: fixed ISO C89/C90 related and other types of warnings

pkarashchenko commented on a change in pull request #5403:
URL: https://github.com/apache/incubator-nuttx/pull/5403#discussion_r798588157



##########
File path: drivers/wireless/ieee80211/bcm43xxx/bcmf_chip_43362.c
##########
@@ -45,39 +45,41 @@ extern const uint8_t bcm43362_firmware_image[];
 extern const unsigned int bcm43362_firmware_image_len;
 #endif
 
-const struct bcmf_sdio_chip bcmf_43362_config_sdio =
+struct bcmf_sdio_chip bcmf_43362_config_sdio;

Review comment:
       Why we can't keen `const` and just add missing items to initializer list?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org