[GitHub] [zookeeper] anmolnar commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK

[GitBox <gi...@apache.org>]

anmolnar commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK
URL: https://github.com/apache/zookeeper/pull/919#discussion_r281657160
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
 ##########
 @@ -184,4 +191,135 @@ public void run() {
             assertArrayEquals("unexpected data", "test".getBytes(StandardCharsets.UTF_8), contents);
         }
     }
+
+    @Test
+    public void testEnableDisableThrottling_secure_random() throws Exception {
 
 Review comment:
   Perhaps I've asked this before, but why don't you use junit's parameterized tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services