You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ocket8888 (via GitHub)" <gi...@apache.org> on 2023/03/01 20:48:40 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7365: Add GHA to update chromedriver

ocket8888 commented on code in PR #7365:
URL: https://github.com/apache/trafficcontrol/pull/7365#discussion_r1122283059


##########
.github/actions/chromedriver-updater/chromedriver_updater/__main__.py:
##########
@@ -0,0 +1,172 @@
+#  Licensed under the Apache License, Version 2.0 (the "License");

Review Comment:
   Our PyLint configuration rates this file at 6.9, mostly with trivially fixable things. For some reason it doesn't like the variable name `pr` - says it isn't snake case. That's the kind of thing I tend to ignore, but I believe the contribution guidelines say to keep to 9+



##########
.github/actions/chromedriver-updater/chromedriver_updater/constants.py:
##########
@@ -0,0 +1,33 @@
+#  Licensed under the Apache License, Version 2.0 (the "License");

Review Comment:
   The only thing stopping this file from getting a perfect linting score is the lack of a module docstring, so that would be an easy win.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org