[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3256: [KYUUBI #3251] fix thrift http frontend connection metrics

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #3256:
URL: https://github.com/apache/incubator-kyuubi/pull/3256#discussion_r947582970


##########
kyuubi-server/src/test/scala/org/apache/kyuubi/operation/thrift/http/KyuubiOperationThriftHttpPerUserSuite.scala:
##########
@@ -34,5 +37,42 @@ class KyuubiOperationThriftHttpPerUserSuite extends KyuubiOperationPerUserSuite
     s"jdbc:hive2://${server.frontendServices.head.connectionUrl}/;transportMode=http;" +
       s"httpPath=cliservice;"
 
-  override protected lazy val httpMode = true;
+  override protected lazy val httpMode = true
+
+  test("test connection metric") {

Review Comment:
   nit: `thrift http connection metrics`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org