[GitHub] [tvm] elvin-n commented on a diff in pull request #13321: [Doc] Add desc of keep_orig_output_dtype for ToMixedPrecision

[GitBox <gi...@apache.org>]

elvin-n commented on code in PR #13321:
URL: https://github.com/apache/tvm/pull/13321#discussion_r1016579452


##########
python/tvm/relay/transform/transform.py:
##########
@@ -1349,6 +1349,13 @@ def ToMixedPrecision(mixed_precision_type="float16", missing_op_mode=1):
         1: Allow missing ops but emit warnings.
         2: Allow missing ops and silently ignore them.
 
+    relay.ToMixedPrecision.keep_orig_output_dtype: boolean
+      Defines if outputs should be retained in original data type or convert to
+      mixed_precision_type. By default this parameter is False and transformation
+      modifies the data types of outputs to mixed_precision_type.
+      This parameter is not part of explicit arguments of the transformation, but should
+      be passed through tvm.transform.PassContext.

Review Comment:
   If we consider this as regular approach of passing parameters, then we don't need to have such example in every and each place of their usages



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org