You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:55:08 UTC
[GitHub] [spark] gengliangwang commented on a change in pull request #32898: [SPARK-35720][SQL] Support casting of String to timestamp without time zone type
gengliangwang commented on a change in pull request #32898:
URL: https://github.com/apache/spark/pull/32898#discussion_r650691762
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1295,8 +1295,14 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
}
}
}
-}
+ test("SPARK-35720: Support casting of String to timestamp without time zone type") {
+ specialTs.foreach { s =>
Review comment:
@pingsutw could you test multiple time zone as the default, similar to https://github.com/apache/spark/pull/32878?
Also, we should test input strings like `2021-06-14 15:01:24+08:00` as well, which expects `2021-06-14 15:01:24`.
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1295,8 +1295,14 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
}
}
}
-}
+ test("SPARK-35720: Support casting of String to timestamp without time zone type") {
+ specialTs.foreach { s =>
Review comment:
@pingsutw could you test multiple time zone as the default, similar to https://github.com/apache/spark/pull/32878?
Also, we should test input strings with time zone like `2021-06-14 15:01:24+08:00` as well, which expects `2021-06-14 15:01:24`.
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1295,8 +1295,14 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
}
}
}
-}
+ test("SPARK-35720: Support casting of String to timestamp without time zone type") {
+ specialTs.foreach { s =>
Review comment:
As I mentioned in https://issues.apache.org/jira/browse/SPARK-35720, I don't think we can simply use `stringToTimestamp` here. You will find that when you have more test cases here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org