You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/26 18:37:51 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4142: Don't Duplicate Offset Index on RowGroupMetadata
tustvold opened a new pull request, #4142:
URL: https://github.com/apache/arrow-rs/pull/4142
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Relates to #4090
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Noticed this whilst working on #4090, it is peculiar to be storing a subset of the page index on `RowGroupMetadata` in addition to at the top-level on `ParquetMetadata`. An argument could perhaps be made for storing the offset and column indices at the `ColumnChunkMetadata` level, but duplicating it at the top-level and the row group level is confusing and does not seem to be necessary.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4142: Don't Duplicate Offset Index on RowGroupMetadata
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4142:
URL: https://github.com/apache/arrow-rs/pull/4142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4142: Don't Duplicate Offset Index on RowGroupMetadata
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4142:
URL: https://github.com/apache/arrow-rs/pull/4142#discussion_r1178265594
##########
parquet/src/file/metadata.rs:
##########
@@ -132,13 +132,25 @@ impl ParquetMetaData {
}
/// Returns page indexes in this file.
+ #[deprecated(note = "Use Self::column_index")]
pub fn page_indexes(&self) -> Option<&ParquetColumnIndex> {
Review Comment:
These accessors were very confusingly named, so I opted to rename them for clarity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4142: Don't Duplicate Offset Index on RowGroupMetadata
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4142:
URL: https://github.com/apache/arrow-rs/pull/4142#discussion_r1178257786
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -999,29 +1004,9 @@ mod tests {
requests: Default::default(),
};
- let options = ArrowReaderOptions::new().with_page_index(true);
Review Comment:
This was just a copy-paste of the test above and was unnecessary, so I opted to just remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org