You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 06:44:51 UTC
[GitHub] [beam] fernando-wizeline opened a new pull request, #23081: GA Migration SQL PreCommit
fernando-wizeline opened a new pull request, #23081:
URL: https://github.com/apache/beam/pull/23081
Adding github actions yaml files.
Updating README and removing jenkins groovy files
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23081: GA Migration SQL PreCommit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23081:
URL: https://github.com/apache/beam/pull/23081#issuecomment-1346437876
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23081: GA Migration SQL PreCommit
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23081:
URL: https://github.com/apache/beam/pull/23081#issuecomment-1450096184
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23081: GA Migration SQL PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23081:
URL: https://github.com/apache/beam/pull/23081#issuecomment-1349241193
Waiting for JIRA tickets to be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23081: GA Migration SQL PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23081:
URL: https://github.com/apache/beam/pull/23081#discussion_r984991453
##########
.github/workflows/job-precommit-sql.yml:
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs Runs Java PreCommit SQL scheduled on cron, on push to master and on pull request
+
+name: PreCommit SQL
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/extensions/sql**']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ sql-precommit:
+ needs: set-properties
+ name: Run PreCommit SQL
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix:
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ exclude: #Skipping Java 11 and 17 due to issues caused by new access options added in JDK 9 and onwards.
Review Comment:
Did this issue exist on Jenkins/why is it showing up on GHA now?
Also, could you file an issue for it?
##########
.github/workflows/job-precommit-sql.yml:
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs Runs Java PreCommit SQL scheduled on cron, on push to master and on pull request
+
+name: PreCommit SQL
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/extensions/sql**']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ sql-precommit:
+ needs: set-properties
+ name: Run PreCommit SQL
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix:
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ exclude: #Skipping Java 11 and 17 due to issues caused by new access options added in JDK 9 and onwards.
+ - java: "11"
+ - java: "17"
+ timeout-minutes: 180
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - name: Setup Java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: ${{ matrix.java }}
+ - name: Remove default github maven configuration
+ # This step is a workaround to avoid a decryption issue of Beam's
+ # gradle-command-action plugin and github's provided maven
+ # settings.xml file
+ shell: bash
+ run: rm ~/.m2/settings.xml
Review Comment:
Is this something we should include in the gradle-command-self-hosted-action itself rather than putting it in multiple workflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23081: GA Migration SQL PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23081:
URL: https://github.com/apache/beam/pull/23081#discussion_r985968859
##########
.github/workflows/job-precommit-sql.yml:
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs Runs Java PreCommit SQL scheduled on cron, on push to master and on pull request
+
+name: PreCommit SQL
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/extensions/sql**']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ sql-precommit:
+ needs: set-properties
+ name: Run PreCommit SQL
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix:
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ exclude: #Skipping Java 11 and 17 due to issues caused by new access options added in JDK 9 and onwards.
Review Comment:
Oh, about this and similar ones: in jenkins, the jar files are being compiled with JDK8 and executed with JDK11 or 17. Most of this errors crop up when compiling with JDK11/17. We tried going the same route in GHA with no success as of yet. We decided to leave the corresponding jenkins jobs untouched.
I opened this issue https://github.com/apache/beam/issues/23068 to resolve this.
##########
.github/workflows/job-precommit-sql.yml:
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs Runs Java PreCommit SQL scheduled on cron, on push to master and on pull request
+
+name: PreCommit SQL
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request_target:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/java/extensions/sql**']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ sql-precommit:
+ needs: set-properties
+ name: Run PreCommit SQL
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix:
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ exclude: #Skipping Java 11 and 17 due to issues caused by new access options added in JDK 9 and onwards.
+ - java: "11"
+ - java: "17"
+ timeout-minutes: 180
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ ref: ${{ github.event.pull_request.head.sha }}
+ persist-credentials: false
+ submodules: false
+ - name: Setup Java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: ${{ matrix.java }}
+ - name: Remove default github maven configuration
+ # This step is a workaround to avoid a decryption issue of Beam's
+ # gradle-command-action plugin and github's provided maven
+ # settings.xml file
+ shell: bash
+ run: rm ~/.m2/settings.xml
Review Comment:
It is included in the setup-self-hosted-action yaml, but for some reason we haven't determined yet the settings.xml file gets created again prior to this step so we have to remove it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23081: GA Migration SQL PreCommit
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23081: GA Migration SQL PreCommit
URL: https://github.com/apache/beam/pull/23081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org