[GitHub] erisu edited a comment on issue #448: CB-13685 android: Adaptive Icon Support

[GitBox <gi...@apache.org>]

erisu edited a comment on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-412155209
 
 
   @janpio I rebased with the latest master.  I also did the same for `cordova-common`'s PR that is associated with this PR. 
   
   The downside, both `cordova-common` and `cordova-android` have `jasmine@^3.1.0` as the dep. Both will update to `3.2.0`, and It seems the `cordova-common` tests already failed for what I believe is the same side-effect of the latest Jasmine's release.
   
   https://github.com/apache/cordova-common/pull/26
   
   I am expecting these tests may show similar side-effects. We might need to update both repo's with the temp fix...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org