You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/08/17 20:09:10 UTC
[PR] [ISSUE #4254] Every utility class should be annotated with @UtilityClass as we are using lombok (eventmesh)
harshithasudhakar opened a new pull request, #4381:
URL: https://github.com/apache/eventmesh/pull/4381
Fixes #4254
### Motivation
Every utility class should be refactored with `@UtilityClass` annotation as we are using lombok.
### Modifications
Annotated all utility classes with `@UtilityClass`
### Documentation
- Does this pull request introduce a new feature? (yes/no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4254] Every utility class should be annotated with @UtilityClass as we are using lombok (eventmesh)
Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar commented on PR #4381:
URL: https://github.com/apache/eventmesh/pull/4381#issuecomment-1684333177
> @harshithasudhakar
>
> * there are other classes that can be annotated with `@UtilityClass` annotation
> * also you can this refactoring in one pull request
> * no need to name your branch with **patch** in the name. This is not really a patch, but a code refactoring. _eventmesh-#issuenumber_ is also a good choice to start with.
Sure, I'll make a PR soon accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4254] Every utility class should be annotated with @UtilityClass as we are using lombok (eventmesh)
Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar commented on PR #4381:
URL: https://github.com/apache/eventmesh/pull/4381#issuecomment-1685043062
If we annotate `@UtilityClass` for this class then the constructor `UrlMappingPattern()` will be flagged as an error by the private constructor automatically generated by lombok. So, do we just leave this class as it was?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4254] Every utility class should be annotated with @UtilityClass as we are using lombok (eventmesh)
Posted by "HattoriHenzo (via GitHub)" <gi...@apache.org>.
HattoriHenzo commented on PR #4381:
URL: https://github.com/apache/eventmesh/pull/4381#issuecomment-1685069908
@harshithasudhakar yes you can leave this class for the moment, the `@UtilityClass` annotation is not applicable to all classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4254] Every utility class should be annotated with @UtilityClass as we are using lombok (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4381:
URL: https://github.com/apache/eventmesh/pull/4381#issuecomment-2057260124
Would delete this unmerged `harshithasudhakar-patch-1` branch because its work has been superseded with https://github.com/apache/eventmesh/pull/4382.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4254] Every utility class should be annotated with @UtilityClass as we are using lombok (eventmesh)
Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar closed pull request #4381: [ISSUE #4254] Every utility class should be annotated with @UtilityClass as we are using lombok
URL: https://github.com/apache/eventmesh/pull/4381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org