You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/03/01 02:32:20 UTC

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3825: Remove callback threadpool for sending add responses

codecov-commenter commented on PR #3825:
URL: https://github.com/apache/bookkeeper/pull/3825#issuecomment-1449240645

   # [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3825](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8dba661) into [master](https://codecov.io/gh/apache/bookkeeper/commit/6d003367280b0a761d02dbfc8c8d6ab8b6637e73?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d00336) will **decrease** coverage by `10.10%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3825       +/-   ##
   =============================================
   - Coverage     68.37%   58.28%   -10.10%     
   + Complexity     6759     5687     -1072     
   =============================================
     Files           473      473               
     Lines         40972    40963        -9     
     Branches       5241     5239        -2     
   =============================================
   - Hits          28015    23875     -4140     
   - Misses        10699    14983     +4284     
   + Partials       2258     2105      -153     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | bookie | `?` | |
   | client | `44.17% <100.00%> (-0.01%)` | :arrow_down: |
   | remaining | `29.59% <66.66%> (+0.08%)` | :arrow_up: |
   | replication | `41.39% <66.66%> (-0.05%)` | :arrow_down: |
   | tls | `20.96% <66.66%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/bookkeeper/conf/ServerConfiguration.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY29uZi9TZXJ2ZXJDb25maWd1cmF0aW9uLmphdmE=) | `63.45% <ø> (-14.22%)` | :arrow_down: |
   | [...ain/java/org/apache/bookkeeper/bookie/Journal.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL0pvdXJuYWwuamF2YQ==) | `76.25% <100.00%> (-6.12%)` | :arrow_down: |
   | [...org/apache/bookkeeper/bookie/ReadOnlyFileInfo.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL1JlYWRPbmx5RmlsZUluZm8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...org/apache/bookkeeper/bookie/datainteg/Events.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL2RhdGFpbnRlZy9FdmVudHMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../apache/bookkeeper/bookie/storage/EntryLogger.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvRW50cnlMb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...eeper/bookie/storage/directentrylogger/Events.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvZGlyZWN0ZW50cnlsb2dnZXIvRXZlbnRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...e/bookkeeper/bookie/datainteg/EntryCopierImpl.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL2RhdGFpbnRlZy9FbnRyeUNvcGllckltcGwuamF2YQ==) | `0.00% <0.00%> (-97.50%)` | :arrow_down: |
   | [.../apache/bookkeeper/bookie/datainteg/WriteSets.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL2RhdGFpbnRlZy9Xcml0ZVNldHMuamF2YQ==) | `0.00% <0.00%> (-96.43%)` | :arrow_down: |
   | [.../storage/directentrylogger/WriterWithMetadata.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvZGlyZWN0ZW50cnlsb2dnZXIvV3JpdGVyV2l0aE1ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-95.66%)` | :arrow_down: |
   | [...ookie/storage/directentrylogger/LogReaderScan.java](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvZGlyZWN0ZW50cnlsb2dnZXIvTG9nUmVhZGVyU2Nhbi5qYXZh) | `0.00% <0.00%> (-95.24%)` | :arrow_down: |
   | ... and [122 more](https://codecov.io/gh/apache/bookkeeper/pull/3825?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org