You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/05 15:32:15 UTC
[GitHub] [airflow] ashb opened a new pull request #12836: Make `airflow --help` run five times quicker
ashb opened a new pull request #12836:
URL: https://github.com/apache/airflow/pull/12836
Importing anything from airflow.models pulls in _a lot_ of airflow, so
delay imports until the functions are called, or make use of the
`TYPE_CHECKING` to not actually import at runtime.
**Before**: mean 2.58s (with a lot of variance)
```
airflow ❯ for i in 1 2 3; do time airflow --help >/dev/null; done
airflow --help > /dev/null 2.00s user 1.39s system 176% cpu 1.928 total
airflow --help > /dev/null 2.84s user 1.43s system 151% cpu 2.817 total
airflow --help > /dev/null 3.00s user 1.37s system 145% cpu 3.009 total
```
**After**: 0.526s
```
airflow --help > /dev/null 0.39s user 0.04s system 99% cpu 0.435 total
airflow --help > /dev/null 0.40s user 0.05s system 99% cpu 0.446 total
airflow --help > /dev/null 0.64s user 0.05s system 99% cpu 0.698 total
```
This also has an advantage in development where a syntax error doesn't
fail with a slightly confusing error message about "unable to configure
logger 'task'".
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12836:
URL: https://github.com/apache/airflow/pull/12836#issuecomment-739345505
> I'd prefer to solve it differently, but pragmatically, this is easiest way now.
I would also like that importing modules had less "side-effects", but...
I think we need both ways -- because fundamentally, even if importing from models imported less code, there's still the fact that in some cases we are _only_ importing it for a type annotation, which is just wasteful at runtime
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12836:
URL: https://github.com/apache/airflow/pull/12836#issuecomment-739329946
[The Workflow run](https://github.com/apache/airflow/actions/runs/402707859) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12836:
URL: https://github.com/apache/airflow/pull/12836#issuecomment-739304345
Discovered with
```
python -X importtime -m airflow version 2>import-trace.log
```
And then [`tuna import-trace.log`](https://github.com/nschloe/tuna)
**Before**
**After**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12836:
URL: https://github.com/apache/airflow/pull/12836#issuecomment-739334640
I'd prefer to solve it differently, but pragmatically, this is easiest way now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #12836:
URL: https://github.com/apache/airflow/pull/12836
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12836:
URL: https://github.com/apache/airflow/pull/12836#issuecomment-739314544
[The Workflow run](https://github.com/apache/airflow/actions/runs/402737123) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryw commented on pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
ryw commented on pull request #12836:
URL: https://github.com/apache/airflow/pull/12836#issuecomment-739310031
watched you code this live :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12836: Make `airflow --help` run five times quicker
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12836:
URL: https://github.com/apache/airflow/pull/12836#issuecomment-739325772
[The Workflow run](https://github.com/apache/airflow/actions/runs/402844832) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org