[GitHub] [rocketmq-apis] aaron-ai commented on a diff in pull request #67: WIP: support pull consumer

["aaron-ai (via GitHub)" <gi...@apache.org>]

aaron-ai commented on code in PR #67:
URL: https://github.com/apache/rocketmq-apis/pull/67#discussion_r1115578303


##########
apache/rocketmq/v2/service.proto:
##########
@@ -244,6 +244,63 @@ message ChangeInvisibleDurationResponse {
   string receipt_handle = 2;
 }
 
+message PullMessageRequest {
+  Resource group = 1;
+  MessageQueue message_queue = 2;
+  int64 offset = 3;
+  int32 batch_size = 4;
+  FilterExpression filter_expression = 5;
+  google.protobuf.Duration long_polling_timeout = 6;
+}
+
+message PullMessageResponse {
+  oneof content {
+    Status status = 1;
+    Message message = 2;
+    int64 next_offset = 3;

Review Comment:
   The `delivery_timestamp` in `ReceiveMessageResponse` aims to perf the latency of gRPC, we could add it in the next pull request.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org