[PR] chore(rust): scope datafusion "sql" feature to the engine crate [sedona-db]

["james-willis (via GitHub)" <gi...@apache.org>]

james-willis opened a new pull request, #1263:
URL: https://github.com/apache/sedona-db/pull/1263

   ## What
   Scope DataFusion's `sql` feature to the `sedona` engine crate instead of enabling it workspace-wide.
   
   ## Why
   `datafusion-expr`'s default features include `sql`, which pulls `sqlparser`, switches `RawBinaryExpr.op` / `RenameSelectItem` to sqlparser types, and gates `datafusion-functions-nested`'s sql planner. Only the `sedona` engine crate uses that surface (`RawBinaryExpr` / `sqlparser`); the function, spatial-join, query-planner and geoparquet crates never do. Enabling it workspace-wide (via `datafusion-expr`'s defaults) forces every downstream consumer onto the sql-gated `datafusion-expr`, which breaks non-sql embedders such as Apache Sail (whose resolver depends on the `not(sql)` forms and cannot compile the sql-gated nested planner).
   
   ## Change
   - `datafusion-expr` → `default-features = false` in the workspace; the `sedona` engine crate opts into `features = ["sql"]`.
   - Drop the unused `sql` feature from `sedona-functions`, `sedona-spatial-join`, `sedona-query-planner`, `sedona-geoparquet`.
   
   ## Verification
   - `cargo check` on those four crates + `sedona-expr` **without** the engine (the embedder scenario) compiles clean — none use the sql surface.
   - The `sedona` engine keeps `sql`; sedona-db's own build unifies it across the workspace, so its build/tests are unchanged.
   
   Draft — CI will run the full test matrix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore(rust): scope datafusion "sql" feature to the engine crate [sedona-db]

["james-willis (via GitHub)" <gi...@apache.org>]

james-willis merged PR #1263:
URL: https://github.com/apache/sedona-db/pull/1263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org