You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/25 19:54:10 UTC
Review Request 26044: Run python style checks in jenkins.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/
-----------------------------------------------------------
Review request for Aurora and Brian Wickman.
Repository: aurora
Description
-------
Run python style checks in jenkins.
Diffs
-----
build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
Diff: https://reviews.apache.org/r/26044/diff/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Bill Farner
Re: Review Request 26044: Run python style checks in jenkins.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/#review54561
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Sept. 25, 2014, 5:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26044/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 5:54 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Run python style checks in jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
>
> Diff: https://reviews.apache.org/r/26044/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26044: Run python style checks in jenkins.
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 25, 2014, 6:03 p.m., Kevin Sweeney wrote:
> > build-support/jenkins/build.sh, lines 27-28
> > <https://reviews.apache.org/r/26044/diff/1/?file=705427#file705427line27>
> >
> > Why's this indirection needed, can't you just do
> >
> > ```bash
> > ./build-support/hooks/pre-commit
> > ```
Yeah, that's a good point - other commands already assume the script is run from the repo root.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/#review54564
-----------------------------------------------------------
On Sept. 25, 2014, 5:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26044/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 5:54 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Run python style checks in jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
>
> Diff: https://reviews.apache.org/r/26044/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26044: Run python style checks in jenkins.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/#review54564
-----------------------------------------------------------
build-support/jenkins/build.sh
<https://reviews.apache.org/r/26044/#comment94749>
Why's this indirection needed, can't you just do
```bash
./build-support/hooks/pre-commit
```
- Kevin Sweeney
On Sept. 25, 2014, 10:54 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26044/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 10:54 a.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Run python style checks in jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
>
> Diff: https://reviews.apache.org/r/26044/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26044: Run python style checks in jenkins.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/#review54570
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Sept. 25, 2014, 11:09 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26044/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 11:09 a.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Run python style checks in jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
>
> Diff: https://reviews.apache.org/r/26044/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26044: Run python style checks in jenkins.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 6:09 p.m.)
Review request for Aurora and Brian Wickman.
Changes
-------
Simplified command, also overrode environment to not allow skipping checks.
Repository: aurora
Description
-------
Run python style checks in jenkins.
Diffs (updated)
-----
build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
Diff: https://reviews.apache.org/r/26044/diff/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Bill Farner