You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/01 05:18:11 UTC

[GitHub] [pulsar] lhotari commented on a change in pull request #11176: [ Tests ] Fixed wrong wait time unit.

lhotari commented on a change in pull request #11176:
URL: https://github.com/apache/pulsar/pull/11176#discussion_r661981739



##########
File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/client/cli/PulsarClientToolTest.java
##########
@@ -186,7 +186,7 @@ public void testDurableSubscribe() throws Exception {
         Assert.assertFalse(future.isCompletedExceptionally());
         future.get();
         //wait for close
-        Awaitility.waitAtMost(Duration.ofDays(2000));
+        Awaitility.waitAtMost(Duration.ofMillis(2000));

Review comment:
       this statement is a no-op. it's the same as calling `Awaitility.await().atMost(Duration.ofMillis(2000))` . We usually omit `.atMost` since the 10 second default value is fine for most cases.
   
   There's probably something missing from this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org