Adding new selectors (was Re: svn commit: r685593)

[Stefan Bodewig <bo...@apache.org>]

On Wed, 13 Aug 2008, <bo...@apache.org> wrote:

> Add readable and writable selectors.

These are File- and ResourceSelectors at the same time.

In order to make them available as ResourceSelectors all I had to do
was

> Modified:
>     ant/core/trunk/src/resources/org/apache/tools/ant/types/resources/selectors/antlib.xml

while making them useful FileSelectors required

> Modified:
>     ant/core/trunk/src/main/org/apache/tools/ant/types/AbstractFileSet.java
>     ant/core/trunk/src/main/org/apache/tools/ant/types/selectors/AbstractSelectorContainer.java
>     ant/core/trunk/src/main/org/apache/tools/ant/types/selectors/BaseSelectorContainer.java

which in each case meant

> +    public void addReadable(ReadableSelector r) {
> +        appendSelector(r);
> +    }
> +
> +    public void addWritable(WritableSelector w) {
> +        appendSelector(w);
> +    }
> +

I vaguely recall that we talked about adding built-in selectors to
another antlib (there is an antlib.xml marked as experimental in
oata) and some selectors are defined in
oata.types/default.properties but I don't recall the outcome.

Could anybody please bring me up to speed whether I'm still supposed
to add new adder methods to the selector containers or if I should
just modify some sort of descriptor to make them named elements (and
if so, which one).

Thanks

        Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org