[GitHub] fmaximus commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing

[gi...@git.apache.org]

fmaximus commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing
URL: https://github.com/apache/cloudstack/pull/2109#discussion_r117335669
 
 

 ##########
 File path: server/src/com/cloud/network/element/VirtualRouterElement.java
 ##########
 @@ -171,6 +171,7 @@
     @Inject
     protected RouterDeploymentDefinitionBuilder routerDeploymentDefinitionBuilder;
 
+    static final ConfigKey<Integer> port= new ConfigKey<Integer>("Network",Integer.class, "network.loadbalancer.haproxy.stats.port", "8081", "Load Balancer(haproxy) stats port number.", true);
 
 Review comment:
   This key is already present in the Config enum class, which is legacy.
   You might consider migrating the usages of the legacy enum value, to your new one.
   Also that might mean, that you have to move it in VirtualRouterElementService interface
   to make sure the plugins can use it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services