You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/07/02 00:21:34 UTC
Review Request 67797: ATLAS-2771: Add option to exclude internal
types when using GET all types using getAllTypeDefs()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2771
https://issues.apache.org/jira/browse/ATLAS-2771
Repository: atlas
Description
-------
Add option to exclude internal types when using GET all types using getAllTypeDefs()
Diffs
-----
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34
Diff: https://reviews.apache.org/r/67797/diff/1/
Testing
-------
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
Thanks,
Sarath Subramanian
Re: Review Request 67797: ATLAS-2771: Add option to exclude internal
types when using GET all types using getAllTypeDefs()
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/#review205622
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 2, 2018, 5:03 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67797/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 5:03 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2771
> https://issues.apache.org/jira/browse/ATLAS-2771
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add option to exclude internal types when using GET all types using getAllTypeDefs()
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34
>
>
> Diff: https://reviews.apache.org/r/67797/diff/2/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 67797: ATLAS-2771: Add option to exclude internal
types when using GET all types using getAllTypeDefs()
Posted by Madhan Neethiraj <ma...@apache.org>.
> On July 2, 2018, 7:30 a.m., Graham Wallis wrote:
> > Do we need a similar filter capability on getAllTypes()?
Graham - this filter applies for getAllTypeDefs() and getTypeDefHeaders(). There is no getAllTypes() in TypesREST; are you referring to a different method/class?
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/#review205621
-----------------------------------------------------------
On July 2, 2018, 5:03 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67797/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 5:03 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2771
> https://issues.apache.org/jira/browse/ATLAS-2771
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add option to exclude internal types when using GET all types using getAllTypeDefs()
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34
>
>
> Diff: https://reviews.apache.org/r/67797/diff/2/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 67797: ATLAS-2771: Add option to exclude internal
types when using GET all types using getAllTypeDefs()
Posted by Graham Wallis <gr...@uk.ibm.com>.
> On July 2, 2018, 7:30 a.m., Graham Wallis wrote:
> > Do we need a similar filter capability on getAllTypes()?
>
> Madhan Neethiraj wrote:
> Graham - this filter applies for getAllTypeDefs() and getTypeDefHeaders(). There is no getAllTypes() in TypesREST; are you referring to a different method/class?
Yes - I couldn't see why we would want to offer this filter only for the REST user - wouldn't the Java interface also benefit from it?
- Graham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/#review205621
-----------------------------------------------------------
On July 2, 2018, 5:03 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67797/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 5:03 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2771
> https://issues.apache.org/jira/browse/ATLAS-2771
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add option to exclude internal types when using GET all types using getAllTypeDefs()
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34
>
>
> Diff: https://reviews.apache.org/r/67797/diff/2/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 67797: ATLAS-2771: Add option to exclude internal
types when using GET all types using getAllTypeDefs()
Posted by Graham Wallis <gr...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/#review205621
-----------------------------------------------------------
Do we need a similar filter capability on getAllTypes()?
- Graham Wallis
On July 2, 2018, 5:03 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67797/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 5:03 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2771
> https://issues.apache.org/jira/browse/ATLAS-2771
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add option to exclude internal types when using GET all types using getAllTypeDefs()
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34
>
>
> Diff: https://reviews.apache.org/r/67797/diff/2/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 67797: ATLAS-2771: Add option to exclude internal
types when using GET all types using getAllTypeDefs()
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/
-----------------------------------------------------------
(Updated July 1, 2018, 10:03 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed review comments.
Bugs: ATLAS-2771
https://issues.apache.org/jira/browse/ATLAS-2771
Repository: atlas
Description
-------
Add option to exclude internal types when using GET all types using getAllTypeDefs()
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34
Diff: https://reviews.apache.org/r/67797/diff/2/
Changes: https://reviews.apache.org/r/67797/diff/1-2/
Testing
-------
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
Thanks,
Sarath Subramanian
Re: Review Request 67797: ATLAS-2771: Add option to exclude internal
types when using GET all types using getAllTypeDefs()
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/#review205617
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java
Line 128 (original), 128 (patched)
<https://reviews.apache.org/r/67797/#comment288488>
Instead of @QueryParam, consider looking for 'excludeInternalTypesAndReferences' in getSearchFilter() to decide whether to apply internal-type filter or not. Also, the param should not be included in the SearchFilter returned from getSearchFilter().
- Madhan Neethiraj
On July 2, 2018, 12:21 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67797/
> -----------------------------------------------------------
>
> (Updated July 2, 2018, 12:21 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2771
> https://issues.apache.org/jira/browse/ATLAS-2771
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add option to exclude internal types when using GET all types using getAllTypeDefs()
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34
>
>
> Diff: https://reviews.apache.org/r/67797/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>