You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/07/12 01:04:50 UTC

[PR] test(agent-service): add unit test coverage for extractOperatorInputPortSchemaMap [texera]

mengw15 opened a new pull request, #6353:
URL: https://github.com/apache/texera/pull/6353

   ### What changes were proposed in this PR?
   
   Add unit test coverage for `extractOperatorInputPortSchemaMap` in `agent-service/src/agent/util/workflow-utils.ts` — a pure function (type-only imports) that maps each input port of an operator to its resolved upstream schema. A `bun test` `.spec.ts` sits next to the source. No production-code changes.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6334.
   
   ### How was this PR tested?
   
   ```
   bun test src/agent/util/workflow-utils.spec.ts
   ```
   
   6 pass. `bun run typecheck` and `bun run format:check` are clean. The spec is pure — it builds `OperatorPredicate` / `OperatorLink` / schema fixtures in-process and covers: no input links → `undefined`; a single port → its keyed schema; an absent source operator; an unparseable source `portID`; link-to-port routing by target port number; and multiple input ports each keyed separately.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(agent-service): add unit test coverage for extractOperatorInputPortSchemaMap [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6353:
URL: https://github.com/apache/texera/pull/6353#issuecomment-4949419347

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6353?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.28%. Comparing base ([`ac39ac8`](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0147758`](https://app.codecov.io/gh/apache/texera/commit/01477585df18ebb084159e9964fa432307d94af5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #6353      +/-   ##
   ============================================
   + Coverage     61.16%   61.28%   +0.11%     
     Complexity     3382     3382              
   ============================================
     Files          1140     1140              
     Lines         44929    44917      -12     
     Branches       4943     4943              
   ============================================
   + Hits          27482    27526      +44     
   + Misses        15930    15874      -56     
     Partials       1517     1517              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.12% <ø> (+1.52%)` | :arrow_up: | |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.58% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `9.97% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.97% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.31% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.18% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [ac39ac8](https://app.codecov.io/gh/apache/texera/commit/ac39ac84aca97b72a35c17ba218c061b52ef1d18?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6353?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(agent-service): add unit test coverage for extractOperatorInputPortSchemaMap [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6353:
URL: https://github.com/apache/texera/pull/6353#issuecomment-4949417744

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - No candidates found from `git blame` history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(agent-service): add unit test coverage for extractOperatorInputPortSchemaMap [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #6353:
URL: https://github.com/apache/texera/pull/6353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org