You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/13 19:03:55 UTC
[GitHub] [nifi] ahmedshaaban1999 opened a new pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group
ahmedshaaban1999 opened a new pull request #5862:
URL: https://github.com/apache/nifi/pull/5862
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ahmedshaaban1999 commented on pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group
Posted by GitBox <gi...@apache.org>.
ahmedshaaban1999 commented on pull request #5862:
URL: https://github.com/apache/nifi/pull/5862#issuecomment-1076264846
@mcgilman I have a question. In the deletion of a multi-selection, why after the snippet is removed we loop the components of the snippet and remove them one by one ?
```
// remove all the non connections in the snippet first
components.each(function (ids, type) {
if (type !== 'Connection') {
nfCanvasUtils.getComponentByType(type).remove(ids);
}
});
// then remove all the connections
if (components.has('Connection')) {
nfConnection.remove(components.get('Connection'));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #5862:
URL: https://github.com/apache/nifi/pull/5862#issuecomment-1074403894
Will review...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ahmedshaaban1999 commented on pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group
Posted by GitBox <gi...@apache.org>.
ahmedshaaban1999 commented on pull request #5862:
URL: https://github.com/apache/nifi/pull/5862#issuecomment-1076153175
Thanks for the feedback,
@thenatog that's strange, I have been facing some problems with whitespaces recently, I will try to double check them using vi and notepadd++
@mcgilman your points are spot on. I tried to tackle both points at first but wasn't successful, though to myself that I can divide the work into two jira tickets. but I agree to get all things done in this ticket. I am currently working on refactoring to make use of the common code as much as possible and at the same time make the message appear when multi-select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on a change in pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group
Posted by GitBox <gi...@apache.org>.
thenatog commented on a change in pull request #5862:
URL: https://github.com/apache/nifi/pull/5862#discussion_r831579776
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-actions.js
##########
@@ -1153,42 +1153,75 @@
if (selection.size() === 1) {
var selectionData = selection.datum();
var revision = nfClient.getRevision(selectionData);
-
- $.ajax({
- type: 'DELETE',
- url: selectionData.uri + '?' + $.param({
- 'version': revision.version,
- 'clientId': revision.clientId,
- 'disconnectedNodeAcknowledged': nfStorage.isDisconnectionAcknowledged()
- }),
- dataType: 'json'
- }).done(function (response) {
- // remove the component/connection in question
- nfCanvasUtils.getComponentByType(selectionData.type).remove(selectionData.id);
-
- // if the selection is a connection, reload the source and destination accordingly
- if (nfCanvasUtils.isConnection(selection) === false) {
- var connections = nfConnection.getComponentConnections(selectionData.id);
- if (connections.length > 0) {
- var ids = [];
- $.each(connections, function (_, connection) {
- ids.push(connection.id);
- });
-
- // remove the corresponding connections
- nfConnection.remove(ids);
- }
- }
-
- // update URL deep linking params
- nfCanvasUtils.setURLParameters();
-
- // refresh the birdseye
- nfBirdseye.refresh();
- // inform Angular app values have changed
- nfNgBridge.digest();
- }).fail(nfErrorHandler.handleAjaxError);
- } else {
+
+ if (nfCanvasUtils.isProcessGroup(selection) === true) {
Review comment:
The whitespacing on this section of code has gone wrong. Can we update the whitespace to align with the rest of the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #5862:
URL: https://github.com/apache/nifi/pull/5862#issuecomment-1080652395
The snippet can contain components of any type on the canvas. There are different objects responsible for managing each type of component. Once the server confirms that the snippet was removed, the UI needs to remove each one from the canvas. In this case, it's actually invoking each `remove` call with an array of ids of all components of each type that should be removed. Another thing to note, there is a behavior that if you delete a component on the server, it also deletes all outgoing connections. There's another loop above the code you referenced that identifies outgoing connections of all components deleted to ensure they are also removed from the canvas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org