You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "Radeity (via GitHub)" <gi...@apache.org> on 2023/07/25 07:28:46 UTC
[GitHub] [incubator-hugegraph] Radeity commented on a diff in pull request #2241: feat(dist): pre-load some data in docker container(#840)
Radeity commented on code in PR #2241:
URL: https://github.com/apache/incubator-hugegraph/pull/2241#discussion_r1273116922
##########
hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh:
##########
@@ -79,13 +79,20 @@ if [ ! -d "$LOGS" ]; then
mkdir -p "$LOGS"
fi
+GERMLIN_SERVER_YAML="gremlin-server.yaml"
+
+if [ $PRELOAD ]; then
Review Comment:
Some tiny suggestion, better use double square brackets to avoid exception if user don't set `PRELOAD`, also, we can add condition check whether the value is true. Like: `if [[ $PRELOAD = "true" ]]; then`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org