[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9610: [hotfix][multistage] support not-in in leaf stage

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #9610:
URL: https://github.com/apache/pinot/pull/9610#discussion_r997595595


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryTestSet.java:
##########
@@ -95,6 +95,10 @@ public Object[][] provideTestSql() {
             + " WHERE a.col1 IN ('foo') AND b.col2 NOT IN ('')"},
 
         // Range conditions with continuous and non-continuous range.
+        new Object[]{"SELECT a.col1, SUM(CASE WHEN a.col2 = 'foo' OR a.col2 = 'alice' THEN 1 ELSE 0 END) AS match_sum, "

Review Comment:
   Might want to add an explicit test in addition to the ones above (that test the functionality provided calcite rewrites) just to ensure this always works even if Calcite ever changes it's mind



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org