You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/04/04 16:45:18 UTC

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP

michaelandrepearce commented on a change in pull request #2609: ARTEMIS-2294 implement duplicate detection for AMQP
URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272269532
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
 ##########
 @@ -971,7 +971,7 @@ public Object getAMQPUserID() {
 
    @Override
    public Object getDuplicateProperty() {
-      return null;
+      return getObjectProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID);
 
 Review comment:
   Surely this should not be Artemis specific but some amqp value

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services