[GitHub] [superset] villebro commented on a change in pull request #16748: ci: bump npm to version 7

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #16748:
URL: https://github.com/apache/superset/pull/16748#discussion_r712089564



##########
File path: scripts/ci_check_no_file_changes.sh
##########
@@ -37,7 +37,7 @@ do
     REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)"
     echo "Searching for changes in python files"
   elif [[ ${CHECK} == "frontend" ]]; then
-    REGEX="(^\.github\/workflows\/.*(frontend|e2e)|^superset-frontend\/)"
+    REGEX="(^\.github\/workflows\/.*(bashlib|frontend|e2e)|^superset-frontend\/)"

Review comment:
       Adding changes in `bashlib.sh` to flag frontend changes, as this file controls many aspects of how dependencies are managed on CI.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org