You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/09/26 04:54:39 UTC

[kudu-CR] [tablet] reduce lock contention in OpTracker::Release()

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21856


Change subject: [tablet] reduce lock contention in OpTracker::Release()
......................................................................

[tablet] reduce lock contention in OpTracker::Release()

Since MemTracker::Release() runs tcmalloc's GC-ing which might
block for some time under heavy concurrent activity, it makes sense
to call it outside of the critical section that guards the map
with pending operations for the tablet.  Also, avoid double lookups
in that map, re-using the iterator for erasing the element.

Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
---
M src/kudu/tablet/ops/op_tracker.cc
1 file changed, 13 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/21856/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Gerrit-Change-Number: 21856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tablet] reduce lock contention in OpTracker::Release()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21856 )

Change subject: [tablet] reduce lock contention in OpTracker::Release()
......................................................................

[tablet] reduce lock contention in OpTracker::Release()

Since MemTracker::Release() runs tcmalloc's GC-ing which might
block for some time under heavy concurrent activity, it makes sense
to call it outside of the critical section that guards the map
with pending operations for the tablet.  Also, avoid double lookups
in that map, re-using the iterator for erasing the element.

Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Reviewed-on: http://gerrit.cloudera.org:8080/21856
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tablet/ops/op_tracker.cc
1 file changed, 13 insertions(+), 7 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Gerrit-Change-Number: 21856
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [tablet] reduce lock contention in OpTracker::Release()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21856 )

Change subject: [tablet] reduce lock contention in OpTracker::Release()
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/547/


-- 
To view, visit http://gerrit.cloudera.org:8080/21856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Gerrit-Change-Number: 21856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 26 Sep 2024 04:54:49 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] reduce lock contention in OpTracker::Release()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21856 )

Change subject: [tablet] reduce lock contention in OpTracker::Release()
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/547/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Gerrit-Change-Number: 21856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 26 Sep 2024 06:59:32 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] reduce lock contention in OpTracker::Release()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21856 )

Change subject: [tablet] reduce lock contention in OpTracker::Release()
......................................................................


Patch Set 1: Verified+1

unrelated test failures


-- 
To view, visit http://gerrit.cloudera.org:8080/21856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Gerrit-Change-Number: 21856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 26 Sep 2024 14:55:57 +0000
Gerrit-HasComments: No

[kudu-CR] [tablet] reduce lock contention in OpTracker::Release()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tablet] reduce lock contention in OpTracker::Release()
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Gerrit-Change-Number: 21856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [tablet] reduce lock contention in OpTracker::Release()

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21856 )

Change subject: [tablet] reduce lock contention in OpTracker::Release()
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e4298ccabe2f70500765d63083cc817b7a5f95
Gerrit-Change-Number: 21856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 26 Sep 2024 06:02:41 +0000
Gerrit-HasComments: No