[GitHub] [accumulo] milleruntime commented on issue #1221: New Security Interface

[GitBox <gi...@apache.org>]

milleruntime commented on issue #1221: New Security Interface
URL: https://github.com/apache/accumulo/issues/1221#issuecomment-504053142
 
 
   I like having this in SPI under a security package: ```org.apache.accumulo.core.spi.security```
   
   Then use ```org.apache.accumulo.core.spi.common.ServiceEnvironment``` as a parameter like so:
   
   ```java
   public interface SecurityModule {
   /**
      * Only called when Accumulo is initiazed.  This will initialize the security for Accumulo.
      *
      * @param configuration SiteConfiguration server configuration
      */
     void initialize(ServiceEnvironment env);
   
     Authenticator authenticator();
     PolicyChecker policyChecker(); // or PermissionsHandler
   
   }
   ```
   
   I am not convinced we need an ```Authenticator``` and an ```Authorizor```.  If we initialize all the security and server side user creds in the initialize method then we can just handle all the authentication stuff with the Authenticator.  Or just have one thing checking permissions and authentication.  There seems to be a lot of duplicate code across all three of our current pluggable interfaces.  There are some methods like: `dropUser, cleanUser and initUser` which will happen after Intialization, where there might be some overlap. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services