You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2016/09/14 11:44:20 UTC

[jira] [Resolved] (OAK-4801) Add test for DNS resolution failure in ClientIpFilter

     [ https://issues.apache.org/jira/browse/OAK-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Mari resolved OAK-4801.
---------------------------------
       Resolution: Fixed
         Assignee: Francesco Mari  (was: Andrei Dulceanu)
    Fix Version/s:     (was: Segment Tar 0.0.20)
                   Segment Tar 0.0.12

Committed with some minor modifications at r1760673.

> Add test for DNS resolution failure in ClientIpFilter
> -----------------------------------------------------
>
>                 Key: OAK-4801
>                 URL: https://issues.apache.org/jira/browse/OAK-4801
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Francesco Mari
>            Priority: Minor
>             Fix For: Segment Tar 0.0.12
>
>         Attachments: OAK-4801-01.patch
>
>
> Per [~frm]'s suggestion, we could refactor a bit {{ClientIpFilter}} and extract the calls to {{InetAddress.getByName()}} into their own interface, say {{InetAddressResolver}}. We could then write a test with bogus implementation of {{InetAddressResolver}} and assert the behaviour of the {{ClientIpFilter}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)