[jira] [Commented] (KAFKA-2146) adding partition did not find the correct startIndex

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901243#comment-14901243 ] 

Guozhang Wang commented on KAFKA-2146:
--------------------------------------

Yeah I agree, could you update the patch?

> adding partition did not find the correct startIndex 
> -----------------------------------------------------
>
>                 Key: KAFKA-2146
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2146
>             Project: Kafka
>          Issue Type: Bug
>          Components: admin
>    Affects Versions: 0.8.2.0
>            Reporter: chenshangan
>            Priority: Minor
>             Fix For: 0.9.0.0
>
>         Attachments: KAFKA-2146.patch
>
>
> TopicCommand provide a tool to add partitions for existing topics. It try to find the startIndex from existing partitions. There's a minor flaw in this process, it try to use the first partition fetched from zookeeper as the start partition, and use the first replica id in this partition as the startIndex.
> One thing, the first partition fetched from zookeeper is not necessary to be the start partition. As partition id begin from zero, we should use partition with id zero as the start partition.
> The other, broker id does not necessary begin from 0, so the startIndex is not necessary to be the first replica id in the start partition. 
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)