You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@mesos.apache.org by "Benjamin Mahler (JIRA)" <ji...@apache.org> on 2015/05/12 01:25:00 UTC

[jira] [Commented] (MESOS-598) Also check 'git diff --shortstat --staged' in post-reviews.py.

    [ https://issues.apache.org/jira/browse/MESOS-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538865#comment-14538865 ] 

Benjamin Mahler commented on MESOS-598:
---------------------------------------

[~pbrett] can you please include the commit when marking as fixed? It's very helpful for posterity. :)

> Also check 'git diff --shortstat --staged' in post-reviews.py.
> --------------------------------------------------------------
>
>                 Key: MESOS-598
>                 URL: https://issues.apache.org/jira/browse/MESOS-598
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Hindman
>            Assignee: Paul Brett
>
> We current check if you have any changes before we run post-reviews.py but we don't check for staged changes which IIUC could get lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)