You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2017/02/03 04:17:51 UTC
[jira] [Commented] (SOLR-10008) Move the reference to CoreContainer
from CoreDescriptor to SolrCore.
[ https://issues.apache.org/jira/browse/SOLR-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851042#comment-15851042 ]
David Smiley commented on SOLR-10008:
-------------------------------------
I don't think there are any back-compat guarantees for this internal stuff, so it's fine by me. If it is easy in some way then fine.
+1 to the patch.
While you're doing this clean-up, can you please add some class level javadocs to some of these classes? e.g. purpose, life-cycle maybe even what class refers to it if applicable. At least just CoreDescriptor as it's very pertinent to this issue.
> Move the reference to CoreContainer from CoreDescriptor to SolrCore.
> --------------------------------------------------------------------
>
> Key: SOLR-10008
> URL: https://issues.apache.org/jira/browse/SOLR-10008
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: trunk, 6.4
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-10008.patch
>
>
> CoreDescriptor referencing CoreContainer is just weird. If anyplace, the SolrCore should have a reference to CoreContainer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org