[GitHub] [flink] matriv commented on a change in pull request #19029: [FLINK-26418][runtime][test] Use java.io.tmpdir for tmpWorkingDir

[GitBox <gi...@apache.org>]

matriv commented on a change in pull request #19029:
URL: https://github.com/apache/flink/pull/19029#discussion_r823661973



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/util/TestingTaskManagerRuntimeInfo.java
##########
@@ -38,7 +38,8 @@
     public TestingTaskManagerRuntimeInfo() {
         this(
                 new Configuration(),
-                System.getProperty("java.io.tmpdir").split(",|" + File.pathSeparator));
+                EnvironmentInformation.getTemporaryFileDirectory()

Review comment:
       I thought about it, but this is a helper class, it's not a "junit" specific class, and I thought we shouldn't use `TemporaryFolder` directly.
   Another idea is to remove ctors with no `tmpWorkingDir` so it's a mandatory argument, and all consumers should be responsible to pass a directory path there, so all the tests using it could pass a junit `TemporaryFolder.newFolder()`.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org