You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/10 22:11:48 UTC
[GitHub] [fineract] hmg65 opened a new pull request, #2590: FINERACT-1741 Introduce Lombok to creditbureau module
hmg65 opened a new pull request, #2590:
URL: https://github.com/apache/fineract/pull/2590
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2590: FINERACT-1741: Introduce Lombok to creditbureau module
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2590:
URL: https://github.com/apache/fineract/pull/2590#discussion_r969647955
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java:
##########
@@ -24,26 +24,34 @@
import javax.persistence.ManyToOne;
import javax.persistence.OneToOne;
import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import lombok.experimental.Accessors;
import org.apache.fineract.infrastructure.core.api.JsonCommand;
import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
@SuppressWarnings({ "MemberName" })
@Entity
@Table(name = "m_creditbureau_loanproduct_mapping")
+@Getter
+@Setter
+@NoArgsConstructor
+@Accessors(chain = true)
public class CreditBureauLoanProductMapping extends AbstractPersistableCustom {
- @Column(name = "is_credit_check_mandatory")
- private boolean isCreditCheckMandatory;
+ @Column(name = "credit_check_mandatory")
+ private boolean creditCheckMandatory;
@Column(name = "skip_credit_check_in_failure")
private boolean skipCreditCheckInFailure;
@Column(name = "stale_period")
private int stalePeriod;
- @Column(name = "is_active")
- private boolean isActive;
+ @Column(name = "active")
Review Comment:
Missing the liquibase script for this change.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java:
##########
@@ -24,26 +24,34 @@
import javax.persistence.ManyToOne;
import javax.persistence.OneToOne;
import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import lombok.experimental.Accessors;
import org.apache.fineract.infrastructure.core.api.JsonCommand;
import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
@SuppressWarnings({ "MemberName" })
@Entity
@Table(name = "m_creditbureau_loanproduct_mapping")
+@Getter
+@Setter
+@NoArgsConstructor
+@Accessors(chain = true)
public class CreditBureauLoanProductMapping extends AbstractPersistableCustom {
- @Column(name = "is_credit_check_mandatory")
- private boolean isCreditCheckMandatory;
+ @Column(name = "credit_check_mandatory")
Review Comment:
Missing the liquibase script for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2590: FINERACT-1741: Introduce Lombok to creditbureau module
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2590:
URL: https://github.com/apache/fineract/pull/2590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] hmg65 commented on a diff in pull request #2590: FINERACT-1741: Introduce Lombok to creditbureau module
Posted by GitBox <gi...@apache.org>.
hmg65 commented on code in PR #2590:
URL: https://github.com/apache/fineract/pull/2590#discussion_r973288751
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java:
##########
@@ -24,26 +24,34 @@
import javax.persistence.ManyToOne;
import javax.persistence.OneToOne;
import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import lombok.experimental.Accessors;
import org.apache.fineract.infrastructure.core.api.JsonCommand;
import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
@SuppressWarnings({ "MemberName" })
@Entity
@Table(name = "m_creditbureau_loanproduct_mapping")
+@Getter
+@Setter
+@NoArgsConstructor
+@Accessors(chain = true)
public class CreditBureauLoanProductMapping extends AbstractPersistableCustom {
- @Column(name = "is_credit_check_mandatory")
- private boolean isCreditCheckMandatory;
+ @Column(name = "credit_check_mandatory")
+ private boolean creditCheckMandatory;
@Column(name = "skip_credit_check_in_failure")
private boolean skipCreditCheckInFailure;
@Column(name = "stale_period")
private int stalePeriod;
- @Column(name = "is_active")
- private boolean isActive;
+ @Column(name = "active")
Review Comment:
undone the change.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauLoanProductMapping.java:
##########
@@ -24,26 +24,34 @@
import javax.persistence.ManyToOne;
import javax.persistence.OneToOne;
import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import lombok.experimental.Accessors;
import org.apache.fineract.infrastructure.core.api.JsonCommand;
import org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
@SuppressWarnings({ "MemberName" })
@Entity
@Table(name = "m_creditbureau_loanproduct_mapping")
+@Getter
+@Setter
+@NoArgsConstructor
+@Accessors(chain = true)
public class CreditBureauLoanProductMapping extends AbstractPersistableCustom {
- @Column(name = "is_credit_check_mandatory")
- private boolean isCreditCheckMandatory;
+ @Column(name = "credit_check_mandatory")
Review Comment:
undone the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org