You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/23 20:23:42 UTC

[GitHub] [kafka] jolshan opened a new pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

jolshan opened a new pull request #10923:
URL: https://github.com/apache/kafka/pull/10923


   Removed the condition to throw the error. Now we only throw when we didn't find the topic ID. 
   Updated the test for IBP < 2.8 that tries to delete topics using ID.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a change in pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#discussion_r657826290



##########
File path: core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala
##########
@@ -94,7 +94,8 @@ class TopicIdWithOldInterBrokerProtocolTest extends BaseRequestTest {
         )).setTimeoutMs(timeout)).build()
     val response = sendDeleteTopicsRequest(request)
     val error = response.errorCounts.asScala
-    assertEquals(2, error(Errors.UNSUPPORTED_VERSION))
+    // Previous versions of the code returned UNSUPPORTED_VERSION

Review comment:
       I think we can remove this comment because `Previous versions of the code` is a little ambiguous.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#issuecomment-869090926


   Hi @dengziming I was following the convention of naming the PR with the same name as the ticket. If it is confusing, we can remove describe from the title.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on a change in pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

Posted by GitBox <gi...@apache.org>.
jolshan commented on a change in pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#discussion_r657920858



##########
File path: core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala
##########
@@ -94,7 +94,8 @@ class TopicIdWithOldInterBrokerProtocolTest extends BaseRequestTest {
         )).setTimeoutMs(timeout)).build()
     val response = sendDeleteTopicsRequest(request)
     val error = response.errorCounts.asScala
-    assertEquals(2, error(Errors.UNSUPPORTED_VERSION))
+    // Previous versions of the code returned UNSUPPORTED_VERSION

Review comment:
       I could specify 2.8 here, but maybe it makes more sense to remove.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete topics call

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10923:
URL: https://github.com/apache/kafka/pull/10923


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#issuecomment-867292878


   I don't think we need to support unsupported version errors in the client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#issuecomment-869082475


   The title says "delete and describe topics calls", but the code only changes delete,  should we reword the title?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete topics call

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #10923:
URL: https://github.com/apache/kafka/pull/10923


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org